Fix memory leaks. #136
Merged
Fix memory leaks. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hill Ma <hillma@google.com>
github-actions
bot
added
🏢 edifice
ahcorde
approved these changes
Dec 7, 2020
mjcarroll
approved these changes
Dec 7, 2020
|
Window failure is unrelated. |
|
Found that the actor world in ign-gazebo is segfaulting after these changes.. The changes here look fine. It could be that we still have pointers pointing to these old data structures after they are being deleted. I think this could happen if we think we are copying these objects but we're actually just copying pointers. We may have to add copy constructors / assignment operators in these classes cc @adlarkin |
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.