Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also set gtest's standard to C++11 #221

Merged
merged 1 commit into from
May 14, 2021
Merged

Also set gtest's standard to C++11 #221

merged 1 commit into from
May 14, 2021

Conversation

mjcarroll
Copy link
Contributor

🦟 Bug fix

Follow-up to #214

@github-actions github-actions bot added 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels May 14, 2021
@chapulina
Copy link
Contributor

It's still unhappy:

[ 44%] Building CXX object test/CMakeFiles/gtest_main.dir/gtest/src/gtest_main.cc.o
In file included from /Users/jenkins/workspace/ignition_common-ci-pr_any-homebrew-amd64/ign-common/test/gtest/src/gtest_main.cc:31:
In file included from /Users/jenkins/workspace/ignition_common-ci-pr_any-homebrew-amd64/ign-common/test/gtest/include/gtest/gtest.h:62:
In file included from /Users/jenkins/workspace/ignition_common-ci-pr_any-homebrew-amd64/ign-common/test/gtest/include/gtest/internal/gtest-internal.h:40:
/Users/jenkins/workspace/ignition_common-ci-pr_any-homebrew-amd64/ign-common/test/gtest/include/gtest/internal/gtest-port.h:836:12: error: no member named 'make_tuple' in namespace 'std'
using std::make_tuple;
      ~~~~~^

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #221 (3af56b5) into ign-common3 (32fd74e) will not change coverage.
The diff coverage is n/a.

❗ Current head 3af56b5 differs from pull request most recent head 5512c08. Consider uploading reports for the commit 5512c08 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #221   +/-   ##
============================================
  Coverage        76.56%   76.56%           
============================================
  Files               73       73           
  Lines            10357    10357           
============================================
  Hits              7930     7930           
  Misses            2427     2427           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fd74e...5512c08. Read the comment docs.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@chapulina chapulina merged commit eb408f0 into ign-common3 May 14, 2021
@chapulina chapulina deleted the gtest_standard branch May 14, 2021 20:50
scpeters pushed a commit to scpeters/ign-common that referenced this pull request Jan 19, 2022
Support for alpha based texture rendering

Approved-by: Louise Poubel <lupoubel@hotmail.com>
Approved-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants