Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cstring for std::memcpy #230

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

kunaltyagi
Copy link
Contributor

Summary

Just a simple fix for a really weird compilation error. Shouldn't have seen it, but saw it, so created a tiny PR

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@kunaltyagi kunaltyagi requested a review from mjcarroll as a code owner July 20, 2021 06:37
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Jul 20, 2021
@mjcarroll
Copy link
Contributor

Thanks for the contribution! Can you signoff your commit so that DCO will pass?

@mjcarroll mjcarroll self-assigned this Jul 20, 2021
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awaiting DCO signoff.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #230 (326ce1e) into ign-common4 (d1f45f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #230   +/-   ##
============================================
  Coverage        76.99%   76.99%           
============================================
  Files               74       74           
  Lines            10563    10563           
============================================
  Hits              8133     8133           
  Misses            2430     2430           
Impacted Files Coverage Δ
graphics/src/Image.cc 67.08% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1f45f4...326ce1e. Read the comment docs.

@mjcarroll
Copy link
Contributor

@kunaltyagi friendly ping on DCO signoff.

Signed-off-by: Kunal Tyagi <tyagi.kunal@live.com>
@kunaltyagi
Copy link
Contributor Author

Sorry for the delay, was on a holiday

@mjcarroll mjcarroll merged commit 465bb77 into gazebosim:ign-common4 Jul 27, 2021
@kunaltyagi kunaltyagi deleted the patch-1 branch July 27, 2021 23:53
scpeters pushed a commit to scpeters/ign-common that referenced this pull request Jan 19, 2022
Port obj invalid mtl fix from gazebo

Approved-by: Ian Chen
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants