-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cstring for std::memcpy
#230
Conversation
Thanks for the contribution! Can you signoff your commit so that DCO will pass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awaiting DCO signoff.
Codecov Report
@@ Coverage Diff @@
## ign-common4 #230 +/- ##
============================================
Coverage 76.99% 76.99%
============================================
Files 74 74
Lines 10563 10563
============================================
Hits 8133 8133
Misses 2430 2430
Continue to review full report at Codecov.
|
@kunaltyagi friendly ping on DCO signoff. |
Signed-off-by: Kunal Tyagi <tyagi.kunal@live.com>
Sorry for the delay, was on a holiday |
Port obj invalid mtl fix from gazebo Approved-by: Ian Chen Signed-off-by: Michael Carroll <michael@openrobotics.org>
Summary
Just a simple fix for a really weird compilation error. Shouldn't have seen it, but saw it, so created a tiny PR
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge