Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macos install instructions #253

Merged
merged 3 commits into from
Sep 27, 2021
Merged

Add macos install instructions #253

merged 3 commits into from
Sep 27, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 24, 2021

Signed-off-by: Alejandro Hernández ahcorde@gmail.com

🦟 Bug fix

Summary

Add macos install instructions

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@ahcorde
Add macos install instructions
16fcd16 
Signed-off-by: Alejandro Hernández <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters September 24, 2021 20:33
@ahcorde ahcorde self-assigned this Sep 24, 2021
@ahcorde ahcorde requested a review from mjcarroll as a code owner September 24, 2021 20:33
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021 •
edited
Loading

Codecov Report

Merging #253 (a74167c) into ign-common4 (14a0daa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common4     #253   +/-   ##
============================================
  Coverage        77.00%   77.00%           
============================================
  Files               75       75           
  Lines            10655    10655           
============================================
  Hits              8205     8205           
  Misses            2450     2450

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14a0daa...a74167c. Read the comment docs.

@chapulina chapulina added documentation Improvements or additions to documentation macOS macOS support labels Sep 24, 2021
mjcarroll
mjcarroll reviewed Sep 27, 2021
View reviewed changes
Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits.

@ahcorde
fix
a74167c 
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from mjcarroll September 27, 2021 15:49
@chapulina chapulina merged commit 8c7697e into ign-common4 Sep 27, 2021
@chapulina chapulina deleted the ahcorde/macos/install branch September 27, 2021 16:57
@chapulina chapulina mentioned this pull request Sep 27, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@scpeters scpeters Awaiting requested review from scpeters

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees

@ahcorde ahcorde

Labels
documentation Improvements or additions to documentation 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress macOS macOS support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @mjcarroll @chapulina