-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for animation tension #256
Conversation
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-common4 #256 +/- ##
===============================================
+ Coverage 77.00% 77.05% +0.04%
===============================================
Files 75 75
Lines 10655 10665 +10
===============================================
+ Hits 8205 8218 +13
+ Misses 2450 2447 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One though on a todo for forward porting.
Is there any integration/unit testing that we can add here?
@osrf-jenkins retest this please |
Signed-off-by: Nate Koenig <nate@openrobotics.org>
Added a test in fb1b612 |
Signed-off-by: Nate Koenig nate@openrobotics.org
🎉 New feature
Summary
PoseAnimation was missing the tension parameter, which was implemented in gazebo classic.
I didn't put this in
ign-common3
because the Animation classes were not PIMPL-ized.Test it
See: gazebosim/gz-sim#1091
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge