Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace migration (narrow) : gz-common #357

Closed
wants to merge 9 commits into from
Closed

ign -> gz Namespace migration (narrow) : gz-common #357

wants to merge 9 commits into from

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebo-tooling/release-tools#711, more narrow alternative to #356

Summary

This is an alternative to #356 (actually using some commits from that branch) that is narrower in scope. It avoids most macro changes in an attempt to simplify the review process.

Once these namespace changes start being merged, things will break, so we will try to merge them all relatively close together in time.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters and others added 6 commits May 21, 2022 00:39
@scpeters
Migrate 'namespace ignition' -> 'namespace gz'
01cd85f 
~~~
sed -i -e 's@namespace ignition@namespace gz@g' \
  $(grep -rlI 'namespace ignition' .)
~~~

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Migrate 'ignition::' -> 'gz::'
f9a5d87 
~~~
sed -i -e 's@ignition::@gz::@g' \
  $(grep -rlI 'ignition::' .)
~~~

Excluded changes to Changelog.md

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@methylDragon @scpeters
Add migration line
9823e4d 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon @scpeters
Add deprecation test
e742eaa 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon @scpeters
Use pragma deprecation message in config.hh
6ecc2f8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon @scpeters
Mention gz headers in migration guide
24f5364 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@scpeters scpeters requested a review from mjcarroll as a code owner May 22, 2022 09:42
@scpeters scpeters changed the title Scpeters/narrow namepsace migration ign -> gz Namespace migration (narrow) : gz-common May 22, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 22, 2022
@methylDragon
Copy link
Contributor

I think this one needs the commits adding the #include <.../config.hh> commits

9b074f8
5aabd90

@methylDragon @scpeters
Include config.hh
22d14c1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon mentioned this pull request May 22, 2022
Closed
@methylDragon @scpeters
Include config.hh in recursive directories and <lib>.hh
4cab2b5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@scpeters
Copy link
Member Author

I think this one needs the commits adding the #include <.../config.hh> commits

9b074f8 5aabd90

thanks! I just cherry-picked them

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 23, 2022
methylDragon
methylDragon requested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was from my dirty commits making it hard to isolate the deprecated_TEST change 🙇

Aside from that I think this is good to go!

test/integration/deprecated_TEST.cc Outdated Show resolved Hide resolved
@scpeters @methylDragon
Update test/integration/deprecated_TEST.cc
6b196a5 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Co-authored-by: methylDragon <methylDragon@gmail.com>
@chapulina
Copy link
Contributor

#356 got in

@chapulina chapulina closed this May 29, 2022
@chapulina chapulina deleted the scpeters/narrow_namepsace_migration branch May 29, 2022 15:02
@scpeters scpeters restored the scpeters/narrow_namepsace_migration branch May 31, 2022 08:50
@scpeters scpeters deleted the scpeters/narrow_namepsace_migration branch June 1, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon requested changes

@chapulina chapulina Awaiting requested review from chapulina

@mjcarroll mjcarroll Awaiting requested review from mjcarroll

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @methylDragon @chapulina