Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces Flips UV flag, removes empty space #420

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 16, 2022

🦟 Bug fix

Fixes #393

Summary

This commit introduces the flip uv flag for unnessary y flip during addition of texture coordinates. Furthermore removes an empty line.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This commit introduces the flip uv flag for unnessary y flip
during addition of texture coordinates. Furthermore removes
an empty line.

Signed-off-by: Onur Berk Tore <otore19@ku.edu.tr>
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #420 (3ff40d1) into main (1635796) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   80.38%   80.38%           
=======================================
  Files          85       85           
  Lines        9944     9944           
=======================================
  Hits         7993     7993           
  Misses       1951     1951           
Impacted Files Coverage Δ
graphics/src/MeshManager.cc 92.20% <ø> (ø)
graphics/src/AssimpLoader.cc 88.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 81c2ebd into gazebosim:main Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants