Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge ign-common3 ➡️ ign-common4 #491

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Mar 4, 2023

➡️ Forward port

Port ign-common3 ➡️ ign-common4

Branch comparison: ign-common4...ign-common3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

ahcorde and others added 5 commits October 26, 2022 08:22
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Version v2 of the actions/checkout workflow is
deprecated, so switch to v3.

Part of gazebo-tooling/release-tools#862.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from mjcarroll as a code owner March 4, 2023 00:47
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Mar 4, 2023
@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Merging #491 (3617422) into ign-common4 (d680f3c) will increase coverage by 3.93%.
The diff coverage is n/a.

❗ Current head 3617422 differs from pull request most recent head cbbbc9c. Consider uploading reports for the commit cbbbc9c to get more accurate results

@@               Coverage Diff               @@
##           ign-common4     #491      +/-   ##
===============================================
+ Coverage        78.92%   82.85%   +3.93%     
===============================================
  Files               75       75              
  Lines             9556     9556              
===============================================
+ Hits              7542     7918     +376     
+ Misses            2014     1638     -376     
Impacted Files Coverage Δ
graphics/include/gz/common/Image.hh 97.05% <ø> (ø)
src/SystemPaths.cc 87.29% <0.00%> (+0.40%) ⬆️
graphics/src/Skeleton.cc 43.11% <0.00%> (+0.88%) ⬆️
graphics/src/NodeAnimation.cc 51.61% <0.00%> (+2.15%) ⬆️
graphics/src/SkeletonAnimation.cc 48.61% <0.00%> (+2.77%) ⬆️
graphics/src/Image.cc 82.81% <0.00%> (+13.67%) ⬆️
profiler/src/RemoteryProfilerImpl.cc 84.13% <0.00%> (+64.82%) ⬆️
graphics/src/STLLoader.cc 76.15% <0.00%> (+72.84%) ⬆️
graphics/src/BVHLoader.cc 87.24% <0.00%> (+87.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mjcarroll mjcarroll merged commit 997c89a into ign-common4 Mar 6, 2023
@mjcarroll mjcarroll deleted the scpeters/merge_3_4 branch March 6, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants