-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to gtest 1.10.0 with patch for gcc warnings #67
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with happy CI
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Retroactive approval, but just a note that we actually package |
this was driven by the use of so they certainly could all be upgraded, but I was just going to prioritize the ones using that macro |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
I noticed a gcc warning about
ISO C++11 requires at least one argument for the "..." in a variadic macro
in #66 related to the use of the gtest macroINSTANTIATE_TEST_CASE_P
:We've faced this before and have added an extra
,
and// NOLINT
:That's not entirely satisfying, and I noticed that this has been fixed in gtest 1.10.0, which renames the
INSTANTIATE_TEST_CASE_P
macro toINSTANTIATE_TEST_SUITE_P
:So this PR updates the fork to gtest 1.10.0. It includes a patch in 61c4cb0 to suppress a separate gcc warning.