Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gtest 1.10.0 with patch for gcc warnings #67

Merged
merged 2 commits into from
May 23, 2020

Conversation

scpeters
Copy link
Member

I noticed a gcc warning about ISO C++11 requires at least one argument for the "..." in a variadic macro in #66 related to the use of the gtest macro INSTANTIATE_TEST_CASE_P:

We've faced this before and have added an extra , and // NOLINT:

That's not entirely satisfying, and I noticed that this has been fixed in gtest 1.10.0, which renames the INSTANTIATE_TEST_CASE_P macro to INSTANTIATE_TEST_SUITE_P:

So this PR updates the fork to gtest 1.10.0. It includes a patch in 61c4cb0 to suppress a separate gcc warning.

scpeters added 2 commits May 22, 2020 16:35
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with happy CI

@scpeters scpeters merged commit 381e65c into gazebosim:ign-common3 May 23, 2020
@scpeters scpeters deleted the gtest_1.10.0 branch May 23, 2020 05:37
scpeters added a commit to scpeters/ign-common that referenced this pull request May 25, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@mjcarroll
Copy link
Contributor

Retroactive approval, but just a note that we actually package gtest in almost all of the ignition repositories, do they need to be updated as well?

@scpeters
Copy link
Member Author

Retroactive approval, but just a note that we actually package gtest in almost all of the ignition repositories, do they need to be updated as well?

this was driven by the use of INSTANTIATE_TEST_CASE_P, which is used in ign-physics and osrf/gazebo for sure, but I'm not sure about other ignition packages

so they certainly could all be upgraded, but I was just going to prioritize the ones using that macro

scpeters added a commit to scpeters/ign-common that referenced this pull request Jun 8, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Jun 9, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll pushed a commit that referenced this pull request Oct 14, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
mjcarroll pushed a commit that referenced this pull request Oct 19, 2020
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants