Skip to content

Commit

Permalink
Revert "Address reviewer feedback"
Browse files Browse the repository at this point in the history
This reverts commit ee7cae2.
  • Loading branch information
mjcarroll committed Sep 10, 2021
1 parent ee7cae2 commit 309d882
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions src/Helpers_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,27 +53,21 @@ TEST(HelpersTEST, UriToPathNoAuthority)
/////////////////////////////////////////////////
TEST(HelpersTEST, UriToPathHasAuthority)
{
#ifdef WIN32
const std::string testStr1 = R"(localhost:8000\some\path)";
const std::string testStr2 = R"(localhost:8000\some\path\)";
#else
const std::string testStr1 = R"(localhost:8000/some/path)";
const std::string testStr2 = R"(localhost:8000/some/path/)";
#endif

{
common::URI uri{"http://localhost:8000", true};
EXPECT_EQ("localhost:8000", uriToPath(uri));
}

{
common::URI uri{"http://localhost:8000/some/path", true};
EXPECT_EQ(testStr1, uriToPath(uri));
EXPECT_EQ(common::joinPaths("localhost:8000", "some", "path"),
uriToPath(uri));
}

{
common::URI uri{"http://localhost:8000/some/path/", true};
EXPECT_EQ(testStr2, uriToPath(uri));
EXPECT_EQ(common::separator(common::joinPaths("localhost:8000", "some",
"path")), uriToPath(uri));
}
}

Expand Down

0 comments on commit 309d882

Please sign in to comment.