5 ➡️ 6 #197
Merged
5 ➡️ 6 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
* Fixed donwload on Windows Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed interface_TEST Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Windows Signed-off-by: Alejandro Hernández <ahcorde@gmail.com> * Fixed test Signed-off-by: ahcorde <ahcorde@gmail.com> * Fix some nits Signed-off-by: ahcorde <ahcorde@gmail.com> * Improved Windows support Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed test on Linux Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed windows tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Fixed tests Signed-off-by: ahcorde <ahcorde@gmail.com> * Added feddback Signed-off-by: ahcorde <ahcorde@gmail.com> * make linters happy Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* added fuel update command Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fixed header Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fixed build Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * updated docs Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * added header Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * fix Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * nit2 Signed-off-by: Tomas Lorente <jtlorente@ekumenlabs.com> * Style, and headers Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fixed world download Signed-off-by: Nate Koenig <nate@openrobotics.org> * Removed debug Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix tests Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fix windows Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
…191) Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools6 #197 +/- ##
===================================================
- Coverage 77.47% 75.55% -1.92%
===================================================
Files 20 20
Lines 2672 2757 +85
===================================================
+ Hits 2070 2083 +13
- Misses 602 674 +72
Continue to review full report at Codecov.
|
|
@osrf-jenkins retest this please |
|
new windows test failure: |
I see this failing on I believe it's caused by some change upstream on I'm going to merge this PR since it didn't introduce the only test failure, and it fixes some of the test failures currently in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port ign-fuel-tools5 to ign-fuel-tools6
Branch comparison: ign-fuel-tools6...ign-fuel-tools5
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)