Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a pretty name for IgnCURL to make error messages less confusing #206

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 24, 2021

🦟 Bug fix

Summary

The error message users get when curl is missing from the system is that IgnCURL is missing, which can be confusing.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 24, 2021
@azeey azeey self-assigned this Sep 24, 2021
@azeey azeey requested a review from nkoenig as a code owner September 24, 2021 18:46
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #206 (3cfd034) into main (bbaf017) will not change coverage.
The diff coverage is n/a.

❗ Current head 3cfd034 differs from pull request most recent head ccbeb6a. Consider uploading reports for the commit ccbeb6a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files          20       20           
  Lines        2757     2757           
=======================================
  Hits         2083     2083           
  Misses        674      674           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbaf017...ccbeb6a. Read the comment docs.

@azeey azeey merged commit 348bef1 into main Sep 27, 2021
@azeey azeey deleted the azeey/fix_curl_name branch September 27, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants