Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : ign-fuel-tools #248

Merged
merged 4 commits into from
May 11, 2022
Merged

ign -> gz Header Migration : ign-fuel-tools #248

merged 4 commits into from
May 11, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from nkoenig as a code owner April 28, 2022 07:35
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 28, 2022
@methylDragon methylDragon mentioned this pull request Apr 28, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Apr 28, 2022
@methylDragon methylDragon marked this pull request as draft April 28, 2022 23:55
chapulina
chapulina approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

include/gz/fuel_tools/Interface.hh
#include <string>
#include "gz/fuel_tools/Export.hh"
#include "gz/fuel_tools/FuelClient.hh"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I just noticed that this header is missing a header guard, I'll add it in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chapulina
Copy link
Contributor

Oh we're missing Export.hh:

   /github/workspace/include/gz/fuel_tools/ClientConfig.hh:27:10: fatal error: gz/fuel_tools/Export.hh: No such file or directory
     27 | #include "gz/fuel_tools/Export.hh"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~

@chapulina chapulina mentioned this pull request May 3, 2022
Merged
8 tasks
@methylDragon
Copy link
Contributor Author

methylDragon commented May 3, 2022 •
edited
Loading

Oh we're missing Export.hh:

   /github/workspace/include/gz/fuel_tools/ClientConfig.hh:27:10: fatal error: gz/fuel_tools/Export.hh: No such file or directory
     27 | #include "gz/fuel_tools/Export.hh"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~

Not sure why this isn't building... I guess I'll get to it eventually 🤔
It's supposed to be a dynamically generated file

@methylDragon
Move header files with git mv (#248)
21ade4a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Create redirection aliases (#248)
716f70b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#248)
5de7524 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate CMake files (#248)
c26e001 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Create redirection aliases (#248)
2b80076 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the header_migration branch 2 times, most recently from 2b80076 to c26e001 Compare May 7, 2022 02:00
@methylDragon
Create redirection aliases (#248)
569fd72 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#248)
0dd26a6 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate CMake files (#248)
8d26ed2 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon marked this pull request as ready for review May 7, 2022 02:02
@methylDragon
Copy link
Contributor Author

CI is failing because of some REST server issue I think

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@79d18d2). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 6af042a differs from pull request most recent head c70db9e. Consider uploading reports for the commit c70db9e to get more accurate results

@@          Coverage Diff           @@
##             main    #248   +/-   ##
======================================
  Coverage        ?   0.00%           
======================================
  Files           ?       1           
  Lines           ?      20           
  Branches        ?       0           
======================================
  Hits            ?       0           
  Misses          ?      20           
  Partials        ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d18d2...c70db9e. Read the comment docs.

@methylDragon
Migrate sources in src, test, examples, and include (#248)
de156c2 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CMake files (#248)
c70db9e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon merged commit a71012e into main May 11, 2022
@methylDragon methylDragon deleted the header_migration branch May 11, 2022 11:26
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Move header files with git mv (#248)
6659e7d 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Create redirection aliases (#248)
9642194 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#248)
c65d7ee 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina