Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable failing windows tests issue #231 #266

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Disable failing windows tests issue #231 #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/CollectionIdentifier_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <gtest/gtest.h>
#include <string>
#include <ignition/common/Console.hh>
#include <ignition/utilities/ExtraTestMacros.hh>

#include "ignition/fuel_tools/ClientConfig.hh"
#include "ignition/fuel_tools/CollectionIdentifier.hh"
Expand All @@ -43,7 +44,8 @@ TEST(CollectionIdentifier, SetFields)

/////////////////////////////////////////////////
/// \brief Unique Name
TEST(CollectionIdentifier, UniqueName)
// See https://github.com/gazebosim/gz-fuel-tools/issues/231
TEST(CollectionIdentifier, IGN_UTILS_TEST_DISABLED_ON_WIN32(UniqueName))
{
ignition::fuel_tools::ServerConfig srv1;
srv1.SetUrl(common::URI("https://localhost:8001/"));
Expand Down
3 changes: 2 additions & 1 deletion src/FuelClient_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,8 @@ TEST_F(FuelClientTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(ModelDependencies))
/////////////////////////////////////////////////
// Windows doesn't support colons in filenames
// https://github.com/ignitionrobotics/ign-fuel-tools/issues/106
TEST_F(FuelClientTest, CachedModel)
// See https://github.com/gazebosim/gz-fuel-tools/issues/231
TEST_F(FuelClientTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(CachedModel))
{
// Configure to use binary path as cache and populate it
ASSERT_EQ(0, ChangeDirectory(PROJECT_BINARY_PATH));
Expand Down
3 changes: 2 additions & 1 deletion src/LocalCache_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ class LocalCacheTest : public ::testing::Test

/////////////////////////////////////////////////
/// \brief Iterate through all models in cache
TEST_F(LocalCacheTest, AllModels)
// See https://github.com/gazebosim/gz-fuel-tools/issues/231
TEST_F(LocalCacheTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(AllModels))
{
ASSERT_EQ(0, ChangeDirectory(PROJECT_BINARY_PATH));
common::removeAll("test_cache");
Expand Down
4 changes: 3 additions & 1 deletion src/ModelIdentifier_TEST.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <gtest/gtest.h>
#include <string>
#include <ignition/common/Console.hh>
#include <ignition/utilities/ExtraTestMacros.hh>

#include "ignition/fuel_tools/ClientConfig.hh"
#include "ignition/fuel_tools/ModelIdentifier.hh"
Expand Down Expand Up @@ -55,7 +56,8 @@ TEST(ModelIdentifier, SetFields)

/////////////////////////////////////////////////
/// \brief Unique Name
TEST(ModelIdentifier, UniqueName)
// See https://github.com/gazebosim/gz-fuel-tools/issues/231
TEST(ModelIdentifier, IGN_UTILS_TEST_DISABLED_ON_WIN32(UniqueName))
{
ignition::fuel_tools::ServerConfig srv1;
srv1.SetUrl(common::URI("https://localhost:8001/"));
Expand Down