Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package deps for harmonic #326

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Update package deps for harmonic #326

merged 2 commits into from
Feb 13, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Feb 11, 2023

Signed-off-by: Ian Chen ichen@openrobotics.org

Now that msgs and transport are recently bumped (to msgs10 and transport13) in harmonic, we need to bump all packages that depend on them. In this case, harmonic should now use fuel-tools9.

I noticed that the package dependency versions were bumped in main in 83077ca. Here I'm just updating all of them to correspond to the correct gz package versions that we currently use in harmonic

Related PR:

Part of gazebo-tooling/release-tools#878

🦟 Bug fix

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from nkoenig as a code owner February 11, 2023 00:27
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033
Copy link
Contributor Author

iche033 commented Feb 13, 2023

The test failure should be fixed by forward porting #319. I'll get this in first and do a forward port from 8 to main to make CI green.

@iche033 iche033 merged commit 0b36586 into main Feb 13, 2023
@iche033 iche033 deleted the harmonic_deps branch February 13, 2023 21:58
@iche033 iche033 added the 🎵 harmonic Gazebo Harmonic label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants