Change inheritance in test

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
gazebosim · Aug 28, 2023 · fc7cebb · fc7cebb
1 parent 6b604ea
commit fc7cebb
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/Application.cc b/src/Application.cc
@@ -267,8 +267,7 @@ Application::~Application()
   }
   this->dataPtr->dialogs.clear();
 
-  if (this->dataPtr->engine)
-    delete this->dataPtr->engine;
+  delete this->dataPtr->engine;
 
   std::queue<std::shared_ptr<Plugin>> empty;
   std::swap(this->dataPtr->pluginsToAdd, empty);

diff --git a/test/plugins/TestBadInheritancePlugin.cc b/test/plugins/TestBadInheritancePlugin.cc
@@ -25,7 +25,7 @@ using namespace gui;
 
 /////////////////////////////////////////////////
 TestBadInheritancePlugin::TestBadInheritancePlugin()
-  : MainWindow()
+  : Dialog ()
 {
 }
 
@@ -36,4 +36,4 @@ TestBadInheritancePlugin::~TestBadInheritancePlugin()
 
 // Register this plugin
 GZ_ADD_PLUGIN(TestBadInheritancePlugin,
-              gui::MainWindow)
+              gui::Dialog)
diff --git a/test/plugins/TestBadInheritancePlugin.hh b/test/plugins/TestBadInheritancePlugin.hh
@@ -20,14 +20,14 @@
 
 #ifndef Q_MOC_RUN
   #include <gz/gui/qt.h>
-  #include <gz/gui/MainWindow.hh>
+  #include <gz/gui/Dialog.hh>
 #endif
 
 namespace gz
 {
   namespace gui
   {
-    class TestBadInheritancePlugin : public MainWindow
+    class TestBadInheritancePlugin : public Dialog
     {
       Q_OBJECT