Add service to change camera follow pgain. #515

bperseghetti · 2023-01-28T04:43:00Z

🦟 Bug fix

Fixes #514

Summary

Now you can set the pgain of the follow camera when following objects. This is needed for extremely high speed objects.

better.mp4

Checklist

Signed all commits for DCO
Added tests
Updated documentation (as needed)
Updated migration guide (as needed)
Consider updating Python bindings (if the library has them)
codecheck passed (See contributing)
All tests passed (See test coverage)
While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

ahcorde · 2023-02-01T16:28:19Z

@osrf-jenkins run tests please!

codecov · 2023-02-03T18:24:16Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dae037) 72.98% compared to head (290c060) 69.18%.
Report is 8 commits behind head on gz-gui7.

❗ Current head 290c060 differs from pull request most recent head bea60bd. Consider uploading reports for the commit bea60bd to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           gz-gui7     #515      +/-   ##
===========================================
- Coverage    72.98%   69.18%   -3.80%     
===========================================
  Files           55       44      -11     
  Lines         4927     4930       +3     
===========================================
- Hits          3596     3411     -185     
- Misses        1331     1519     +188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

examples/standalone/scene_provider/README.md

src/plugins/follow_config/CMakeLists.txt

src/plugins/follow_config/FollowConfig.cc

test/integration/follow_config.cc

src/plugins/camera_tracking/CameraTracking.cc

src/plugins/follow_config/FollowConfig.cc

iche033

the new service calls and Follow Config plugin work well for me

test/integration/follow_config.cc

azeey · 2023-03-02T00:00:53Z

src/plugins/follow_config/FollowConfig.cc

+
+  msgs::StringMsg reqName;
+  reqName.set_data(this->followTargetName);
+  node.Request(this->followTargetNameService, reqName, cbName);


If you're using async service requests, you'll need to synchronize access to all the variables used by the callback since the callbacks will happen from a different thread than the Qt thread. This could help with the CI failure.

Alternatively, just copy-capture the variable in the lambda. I think this is a lot easier.

Will finally get back to looking at this.

@bperseghetti did you address the feedback ?

mjcarroll · 2023-08-29T21:38:04Z

@bperseghetti I haven't seen any movement on this one and it targets garden branches, so I'm going to remove the beta label for now.

caguero · 2024-01-05T17:21:48Z

@bperseghetti , friendly ping. Could you review the feedback and we'll try to merge this patch?

bperseghetti · 2024-01-05T18:21:05Z

@bperseghetti , friendly ping. Could you review the feedback and we'll try to merge this patch?

Yeah, will look it over again here this weekend and see if I can't make the requested changes.

Example: gz service -s /gui/follow/pgain --reqtype gz.msgs.Double --reptype gz.msgs.Boolean --timeout 2000 --req 'data: 1.0' Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

Allows for follow camera control set from sdf as well as gui. Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

White space cleanup. Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

jennuine · 2024-02-02T19:11:46Z

@bperseghetti there are CI errors:

/home/jenkins/workspace/gz_gui-ci-pr_any-focal-amd64/gz-gui/test/integration/follow_config.cc:162
Expected: (sleep) < (maxSleep), actual: 61 vs 60

bperseghetti · 2024-02-05T19:11:38Z

@bperseghetti there are CI errors:

/home/jenkins/workspace/gz_gui-ci-pr_any-focal-amd64/gz-gui/test/integration/follow_config.cc:162
Expected: (sleep) < (maxSleep), actual: 61 vs 60

I actually was planning to close this and open a new PR that has a more "holistic" approach to controlling the follow camera including what was done in here but more.

I just need to rebase that work on humble as I no longer plan to target it to garden (due to relatively sooner EOL).

bperseghetti · 2024-05-10T06:14:42Z

Closing in favor of PR #619

bperseghetti requested a review from jennuine as a code owner January 28, 2023 04:43

github-actions bot added the 🌱 garden Ignition Garden label Jan 28, 2023

ahcorde approved these changes Feb 1, 2023

View reviewed changes

ahcorde enabled auto-merge (squash) February 1, 2023 16:28

auto-merge was automatically disabled February 3, 2023 06:33
Head branch was pushed to by a user without write access

bperseghetti force-pushed the pr-set-follow-camera-pgain branch 3 times, most recently from e596e32 to 290c060 Compare February 3, 2023 17:12

bperseghetti force-pushed the pr-set-follow-camera-pgain branch 2 times, most recently from 6150395 to ed5167d Compare February 3, 2023 20:51

ahcorde requested changes Feb 8, 2023

View reviewed changes

iche033 reviewed Feb 8, 2023

View reviewed changes

src/plugins/camera_tracking/CameraTracking.cc Outdated Show resolved Hide resolved

src/plugins/follow_config/FollowConfig.cc Outdated Show resolved Hide resolved

bperseghetti force-pushed the pr-set-follow-camera-pgain branch from c386760 to 66fbe33 Compare February 9, 2023 03:06

iche033 reviewed Feb 9, 2023

View reviewed changes

ahcorde reviewed Feb 9, 2023

View reviewed changes

test/integration/follow_config.cc Outdated Show resolved Hide resolved

bperseghetti force-pushed the pr-set-follow-camera-pgain branch from 66fbe33 to c265538 Compare February 13, 2023 13:24

ahcorde approved these changes Feb 13, 2023

View reviewed changes

bperseghetti force-pushed the pr-set-follow-camera-pgain branch from c265538 to 55e73fe Compare February 13, 2023 14:42

mjcarroll approved these changes Feb 13, 2023

View reviewed changes

azeey requested changes Mar 2, 2023

View reviewed changes

azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023

mjcarroll removed the beta Targeting beta release of upcoming collection label Aug 29, 2023

Add service to change camera follow pgain.

b6b7fd2

Example: gz service -s /gui/follow/pgain --reqtype gz.msgs.Double --reptype gz.msgs.Boolean --timeout 2000 --req 'data: 1.0' Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

bperseghetti force-pushed the pr-set-follow-camera-pgain branch from 935c53c to 568545f Compare January 7, 2024 18:46

bperseghetti and others added 2 commits January 7, 2024 13:56

Apply suggestions from code review

91408d8

White space cleanup. Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

Allow camera tracking to listen to SDF.

bea60bd

Signed-off-by: Benjamin Perseghetti <bperseghetti@rudislabs.com>

Jaeyoung-Lim mentioned this pull request Feb 27, 2024

Follow model in gz GUI PX4/PX4-Autopilot#22808

Merged

bperseghetti mentioned this pull request May 10, 2024

Enhanced tracking camera and user visualization experience #619

Merged

9 tasks

bperseghetti closed this May 10, 2024

srmainwaring mentioned this pull request Feb 1, 2024

GUI camera doesn't keep manual orientation changes when in Follow entity mode #628

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service to change camera follow pgain. #515

Add service to change camera follow pgain. #515

bperseghetti commented Jan 28, 2023 •

edited

Loading

ahcorde commented Feb 1, 2023

codecov bot commented Feb 3, 2023 •

edited

Loading

iche033 left a comment

azeey Mar 2, 2023 •

edited

Loading

azeey Mar 2, 2023

bperseghetti Jun 1, 2023

ahcorde Jul 20, 2023

mjcarroll commented Aug 29, 2023

caguero commented Jan 5, 2024

bperseghetti commented Jan 5, 2024

jennuine commented Feb 2, 2024

bperseghetti commented Feb 5, 2024

bperseghetti commented May 10, 2024

Add service to change camera follow pgain. #515

Add service to change camera follow pgain. #515

Conversation

bperseghetti commented Jan 28, 2023 • edited Loading

🦟 Bug fix

Summary

Checklist

ahcorde commented Feb 1, 2023

codecov bot commented Feb 3, 2023 • edited Loading

Codecov Report

iche033 left a comment

Choose a reason for hiding this comment

azeey Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

azeey Mar 2, 2023

Choose a reason for hiding this comment

bperseghetti Jun 1, 2023

Choose a reason for hiding this comment

ahcorde Jul 20, 2023

Choose a reason for hiding this comment

mjcarroll commented Aug 29, 2023

caguero commented Jan 5, 2024

bperseghetti commented Jan 5, 2024

jennuine commented Feb 2, 2024

bperseghetti commented Feb 5, 2024

bperseghetti commented May 10, 2024

bperseghetti commented Jan 28, 2023 •

edited

Loading

codecov bot commented Feb 3, 2023 •

edited

Loading

azeey Mar 2, 2023 •

edited

Loading