Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 3.5.0 #188

Merged
merged 1 commit into from
Mar 10, 2021
Merged

🎈 3.5.0 #188

merged 1 commit into from
Mar 10, 2021

Conversation

chapulina
Copy link
Contributor

🎈 Release

Preparation for 3.5.0 release.

Comparison to 3.4.0: ignition-gui3_3.4.0...ign-gui3

Needed by gazebosim/gz-sim#588

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in ignition-release (as needed):

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from jennuine March 10, 2021 19:31
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #188 (9dc3b2f) into ign-gui3 (3df3ad6) will increase coverage by 44.67%.
The diff coverage is 59.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-gui3     #188       +/-   ##
=============================================
+ Coverage     14.55%   59.23%   +44.67%     
=============================================
  Files            13       23       +10     
  Lines          1333     2730     +1397     
=============================================
+ Hits            194     1617     +1423     
+ Misses         1139     1113       -26     
Impacted Files Coverage Δ
include/ignition/gui/Helpers.hh 100.00% <ø> (+100.00%) ⬆️
include/ignition/gui/Plugin.hh 100.00% <ø> (+100.00%) ⬆️
src/ign.cc 37.83% <ø> (+37.83%) ⬆️
src/plugins/grid_3d/Grid3D.cc 28.57% <0.00%> (ø)
src/plugins/image_display/ImageDisplay.cc 23.27% <ø> (ø)
src/plugins/publisher/Publisher.cc 90.78% <ø> (ø)
src/plugins/scene3d/Scene3D.cc 12.78% <0.00%> (ø)
src/Plugin.cc 57.44% <22.22%> (+57.44%) ⬆️
src/plugins/screenshot/Screenshot.cc 25.71% <25.71%> (ø)
src/plugins/key_publisher/KeyPublisher.cc 56.52% <56.52%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52a4e96...9dc3b2f. Read the comment docs.

Copy link
Contributor

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennuine jennuine merged commit 09fd5f7 into ign-gui3 Mar 10, 2021
@jennuine jennuine deleted the chapulina/3.5.0 branch March 10, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants