Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate scene3D with ign-gui #217

Closed
wants to merge 2 commits into from
Closed

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Apr 29, 2021

🎉 New feature

This PR is part of the consolidation of Scene3D with ign-gazebo's GzScene3D #137

Related to:

Summary

Make the ign-gui plugin extensible

I have create a new Plugin to test this new structure called Scene3DNew. I tried to launch it with ign gui -s Scene3dNew but for some reason it crash.

The other option is to use the windows example an change the plugin to Scene3DNew

Right now supports:

  • Models in the scene
  • Sky
  • moveTo
  • follow
  • Fullscreen
  • Engine
  • Ambient light
  • background
  • camera pose

Test it

Checklist

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 29, 2021
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Apr 29, 2021
@ahcorde ahcorde changed the base branch from ign-gui5 to main April 29, 2021 20:23
@ahcorde ahcorde changed the title Ahcorde/redesign scene3d Consolidate scene3D with ign-gui Apr 29, 2021
Signed-off-by: ahcorde <ahcorde@gmail.com>
@chapulina chapulina added 🏯 fortress Ignition Fortress and removed 🏢 edifice Ignition Edifice labels May 5, 2021
@ahcorde
Copy link
Contributor Author

ahcorde commented Jun 22, 2021

Closing this PR in favour of this other PR #221

@ahcorde ahcorde closed this Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants