Fix crash when starting Grid3D plugin #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `Grid3DPrivate::engine` happens not to be a nullptr during allocation, it will never be correctly initialized and will later try to dereference an invalid ptr Just in case we also initialize quickWindow although it doesn't seem to be strictly necessary. Signed-off-by: Matias N. Goldberg <dark_sylinc@yahoo.com.ar>
|
Done in #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Grid3DPrivate::enginehappens not to be a nullptr duringallocation, it will never be correctly initialized and will later try to
dereference an invalid ptr
Just in case we also initialize quickWindow although it doesn't seem to
be strictly necessary.
Signed-off-by: Matias N. Goldberg dark_sylinc@yahoo.com.ar
Summary
Self-explanatory. I ran into this bug by chance. Just open the Grid3D plugin from the GUI and it will crash (unless you're lucky that Grid3DPrivate::engine ended up being nullptr).
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge