Set cameraPassCountPerGpuFlush to 6 #381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Chen ichen@osrfoundation.org
🦟 Bug fix
Summary
The API was added in gazebosim/gz-rendering#353 to optimize performance and also affects particle effects. It is set in ign-gazebo's Scene3D plugin:
https://github.com/ignitionrobotics/ign-gazebo/blob/39a0ce3712580e855838cf7557013a262d42e1a1/src/gui/plugins/scene3d/Scene3D.cc#L2126
looks like we missed it when porting it over to ign-gui's minimal scene 3d plugin.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.