Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cameraPassCountPerGpuFlush to 6 #381

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Apr 4, 2022

Signed-off-by: Ian Chen ichen@osrfoundation.org

🦟 Bug fix

Summary

The API was added in gazebosim/gz-rendering#353 to optimize performance and also affects particle effects. It is set in ign-gazebo's Scene3D plugin:
https://github.com/ignitionrobotics/ign-gazebo/blob/39a0ce3712580e855838cf7557013a262d42e1a1/src/gui/plugins/scene3d/Scene3D.cc#L2126

looks like we missed it when porting it over to ign-gui's minimal scene 3d plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Apr 4, 2022
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #381 (1363ad9) into ign-gui6 (9b0cd1f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           ign-gui6     #381   +/-   ##
=========================================
  Coverage     65.53%   65.54%           
=========================================
  Files            39       39           
  Lines          5142     5143    +1     
=========================================
+ Hits           3370     3371    +1     
  Misses         1772     1772           
Impacted Files Coverage Δ
src/plugins/minimal_scene/MinimalScene.cc 64.10% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0cd1f...1363ad9. Read the comment docs.

@iche033 iche033 merged commit a2497cb into ign-gui6 Apr 5, 2022
@iche033 iche033 deleted the camera_pass_gpu_flush branch April 5, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants