Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort plugin list in alphabetical order (including when filtering) #387

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

mabelzhang
Copy link
Contributor

@mabelzhang mabelzhang commented Apr 14, 2022

Signed-off-by: Mabel Zhang mabel@openrobotics.org

🎉 New feature

Closes gazebosim/gz-sim#175
Follows up on #277

Summary

Sort plugin menu in alphabetical order by overriding lessThan, the default defined in include/ignition/gui/qml/IgnSortFilterModel.qml.

Test it

ign gui

Click on the three vertical dots in the upper-right corner for the plugin menu.

Before (not sorted):
2022-04-13-204024_1200x1000_scrot_unsorted

After (sorted alphabetically):
2022-04-13-203943_1200x1000_scrot_sorted

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang added 🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience labels Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #387 (bfc4c04) into ign-gui3 (5a02f30) will decrease coverage by 28.44%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           ign-gui3     #387       +/-   ##
=============================================
- Coverage     59.57%   31.12%   -28.45%     
=============================================
  Files            20       29        +9     
  Lines          2471     1343     -1128     
=============================================
- Hits           1472      418     -1054     
+ Misses          999      925       -74     
Impacted Files Coverage Δ
include/ignition/gui/GuiEvents.hh
include/ignition/gui/Helpers.hh
include/ignition/gui/Plugin.hh
src/Application.cc
src/Conversions.cc
src/Helpers.cc
src/MainWindow.cc
src/Plugin.cc
src/ign.cc
src/plugins/image_display/ImageDisplay.cc
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd66a8...bfc4c04. Read the comment docs.

@chapulina chapulina merged commit aafacbf into ign-gui3 Apr 14, 2022
@chapulina chapulina deleted the mabelzhang/sort_plugins branch April 14, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants