Fix common widget Pose #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youhy <haoyuan2019@outlook.com>
Codecov Report
@@ Coverage Diff @@
## ign-gui3 #431 +/- ##
=========================================
Coverage 66.12% 66.12%
=========================================
Files 29 29
Lines 3218 3218
=========================================
Hits 2128 2128
Misses 1090 1090 Continue to review full report at Codecov.
|
jennuine
reviewed
Jul 5, 2022
There was a problem hiding this comment.
Left some comments from the original PR to help make it easier to track. This one needs to be addressed as well: #424 (comment)
include/ignition/gui/qml/GzPose.qml
Outdated
| @@ -66,6 +66,9 @@ Item { | |||
| */ | |||
| signal gzPoseSet(double _x, double _y, double _z, double _roll, double _pitch, double _yaw) | |||
|
|
|||
| // Maximum spinbox value | |||
| property double spinMax: Number.MAX_VALUE | |||
|
|
|||
|
|
|||
| /*** The following are private variables: ***/ | |||
| // Show Pose bar (used to control expand) | |||
There was a problem hiding this comment.
Continuing this conversation: #424 (comment)
If the parent is controlling show, then we should move it out of the private variables comment
There was a problem hiding this comment.
More on this here: #424 (comment)
Signed-off-by: youhy <haoyuan2019@outlook.com>
jennuine
approved these changes
Jul 7, 2022
jennuine
reviewed
Jul 7, 2022
Signed-off-by: youhy <haoyuan2019@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youhy haoyuan2019@outlook.com
Feature patch
Make changes for common widget
GzPose.qmlaccording to #424Summary
Behavior should be exactly the same as before.
Can also be tested with gz-sim#1571
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.