-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port: 7 to main #564
Merged
Merged
Port: 7 to main #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Break scene3d test apart into component tests Signed-off-by: Michael Carroll <michael@openrobotics.org> * Fix include paths Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove scene3d as it is deprecated Signed-off-by: Michael Carroll <michael@openrobotics.org> * Remove message header Signed-off-by: Michael Carroll <michael@openrobotics.org> * Bump everything to ogre2 by default Signed-off-by: Michael Carroll <michael@openrobotics.org> * line order Signed-off-by: Louise Poubel <louise@openrobotics.org> * Fix tests by delaying get render engine calls (#535) --------- Signed-off-by: Ian Chen <ichen@openrobotics.org> * revert default engine Signed-off-by: Ian Chen <ichen@openrobotics.org> * Fix rendering tests (#561) * debugging Signed-off-by: Ian Chen <ichen@openrobotics.org> * reset cam Signed-off-by: Ian Chen <ichen@openrobotics.org> * more testing Signed-off-by: Ian Chen <ichen@openrobotics.org> * no unload Signed-off-by: Ian Chen <ichen@openrobotics.org> * more testing with no unload Signed-off-by: Ian Chen <ichen@openrobotics.org> * unload engine in gzrenderer Signed-off-by: Ian Chen <ichen@openrobotics.org> * unload engine in gzrenderer debugging Signed-off-by: Ian Chen <ichen@openrobotics.org> * unload engine in gzrenderer reset scene Signed-off-by: Ian Chen <ichen@openrobotics.org> * comment out unload Signed-off-by: Ian Chen <ichen@openrobotics.org> * increase timeout Signed-off-by: Ian Chen <ichen@openrobotics.org> * test timing Signed-off-by: Ian Chen <ichen@openrobotics.org> * cleanup Signed-off-by: Ian Chen <ichen@openrobotics.org> * cleanup Signed-off-by: Ian Chen <ichen@openrobotics.org> * more cleanup Signed-off-by: Ian Chen <ichen@openrobotics.org> --------- Signed-off-by: Ian Chen <ichen@openrobotics.org> * Suppress warnings in metal Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> * Incorrect args Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> --------- Signed-off-by: Michael Carroll <michael@openrobotics.org> Signed-off-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Ian Chen <ichen@openrobotics.org> Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
ahcorde
approved these changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 70.09% 68.05% -2.04%
==========================================
Files 46 38 -8
Lines 5062 5394 +332
==========================================
+ Hits 3548 3671 +123
- Misses 1514 1723 +209
|
iche033
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-gui7 to main
Branch comparison: main...gz-gui7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)