Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at level1 clazy checks for qt #584

Merged
merged 7 commits into from
Nov 13, 2023
Merged

First pass at level1 clazy checks for qt #584

merged 7 commits into from
Nov 13, 2023

Conversation

mjcarroll
Copy link
Contributor

Cleaning up clazy warnings to make sure we are using Qt correctly.

@mjcarroll mjcarroll self-assigned this Oct 13, 2023
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll force-pushed the mjcarroll/implptr branch 2 times, most recently from b84c93f to 20bf135 Compare November 7, 2023 22:15
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Base automatically changed from mjcarroll/implptr to main November 10, 2023 14:44
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (ce37179) 70.05% compared to head (4319ec7) 70.14%.

❗ Current head 4319ec7 differs from pull request most recent head bc58d59. Consider uploading reports for the commit bc58d59 to get more accurate results

Files Patch % Lines
src/plugins/point_cloud/PointCloud.cc 30.76% 9 Missing ⚠️
src/plugins/screenshot/Screenshot.cc 0.00% 4 Missing ⚠️
src/plugins/grid_config/GridConfig.cc 0.00% 3 Missing ⚠️
src/plugins/marker_manager/MarkerManager.cc 25.00% 3 Missing ⚠️
src/plugins/topic_viewer/TopicViewer.cc 0.00% 3 Missing ⚠️
src/plugins/world_control/WorldControl.cc 72.72% 3 Missing ⚠️
src/PlottingInterface.cc 90.00% 2 Missing ⚠️
src/Plugin.cc 93.93% 2 Missing ⚠️
src/Application.cc 96.29% 1 Missing ⚠️
src/MainWindow.cc 96.15% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   70.05%   70.14%   +0.09%     
==========================================
  Files          38       38              
  Lines        5356     5343      -13     
==========================================
- Hits         3752     3748       -4     
+ Misses       1604     1595       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll marked this pull request as ready for review November 10, 2023 15:44
@mjcarroll mjcarroll requested a review from jennuine as a code owner November 10, 2023 15:44
src/MainWindow_TEST.cc Outdated Show resolved Hide resolved
src/MainWindow_TEST.cc Show resolved Hide resolved
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll merged commit 352e726 into main Nov 13, 2023
10 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/clazy branch November 13, 2023 23:25
@mjcarroll mjcarroll mentioned this pull request Jan 29, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants