Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qt6 WIP #596

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

Qt6 WIP #596

wants to merge 39 commits into from

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Nov 10, 2023 •
edited by azeey
Loading

Toward #586

This is in no way ready, but just to be publicly accountable for progress ;)

@mjcarroll
Change main gui classes to implptr
4f98aa3 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Switch gz-gui plugins to use implptr
ed63b7b 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
First pass at level1 clazy checks for qt
2052269 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge branch 'main' into mjcarroll/clazy
5e9bc27 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Lint
364fbca 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll marked this pull request as draft November 10, 2023 15:32
@mjcarroll mjcarroll self-assigned this Nov 10, 2023
@mjcarroll
Make use of auto* more consistent
273fac0 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Make cmake qt-version agnostic
44bd786 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
lambda capture
bc58d59 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge branch 'mjcarroll/clazy' into mjcarroll/qt5qt6
451450a
@mjcarroll
Remove qt5 from examples
6c35be0 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Remove Qt < 5.15 logic
126b690 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Additional qt5 cmake functions
ffa6430 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
@wip
d7c9adf 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
@wip
aefb832 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll changed the base branch from main to mjcarroll/qt5qt6 November 13, 2023 22:09
@mjcarroll
Fix conversions test
6ebe89c 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Make using deprecated APIs an error
fa6e270 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fix vulkan call and qregexp
9f6c81c 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fix test logic
8eba03e 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Qt5.15 compatible graphics updates
22cb41a 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fix extra header
4c7d46d 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Lint
7584829 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge branch 'main' into mjcarroll/qt5qt6
06c80fd
@mjcarroll
Fix preprocessor
5ee29c6 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fix indent
b255e56 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fix regex use
dffd3a0 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge branch 'mjcarroll/qt5qt6' into mjcarroll/qt6
a5ed392 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Fixing QML files
d6516d9
@mjcarroll
Align all plugins
47c92c2 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Updating plugins
861f355 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Base automatically changed from mjcarroll/qt5qt6 to main December 8, 2023 22:56
@mjcarroll mjcarroll mentioned this pull request Jan 29, 2024
Open
14 tasks
@mjcarroll
Fix installation
2ec0c07 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Merge branch 'main' into mjcarroll/qt6
0214391 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@caguero
Updates
bcf1e09 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Merge branch 'main' into mjcarroll/qt6
e2f1eae
@caguero
OpenGL
8db1277 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Plugin updates.
1f28e07 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Copy link
Contributor

caguero commented Jul 19, 2024

Plugin status after 1f28e07: This list evaluates whether the plugin loads or not. It doesn't check its full functionality.

  • MarkerManager
  • NavSatMap:  It doesn't load. Can't find module QtLocation. It seems that his module is available starting from Qt 6.5.x
  • TopicEcho
  • TransportPlotting
  • Screenshot
  • WorldControl
  • TransportSceneManager
  • ShutdownButton
  • Teleop
  • CameraTracking
  • KeyPublisher
  • TapeMeasure
  • TopicViewer:  Loads commenting many of the properties of TreeView, including delegates.
  • CameraFps
  • Publisher
  • ImageDisplay: Loads OK but I don't see the list of topics updated.
  • PointCloud
  • GridConfig: Loads but requires an updated version of GzSpinBox to be functional
  • WorldStats
  • MinimalScene:  Loads OK passing a config file with the engine name, etc.
  • InteractiveViewControl

@jennuine
Copy link
Contributor

Posting here as a friendly reminder once we've finished Qt6 migration to test out seting the flags of its RHI texture to sRGB color space before we potentially port the #629 workaround.

@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
caguero and others added 3 commits August 5, 2024 19:09
@caguero
GzSpinBox update
7cf5f94 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@azeey
Fix a few issues with spinbox
96d791a 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey
WIP: GzSplit
872ea46 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 16, 2024
@caguero
Tweak
9f743eb 
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
Core development
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjcarroll @caguero @jennuine @azeey