3 ➡️ 4 #101
Merged
3 ➡️ 4 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 3.1.0 release prep Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added PR 68 to changelog Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Fix env parsing by placing it before executable parsing Signed-off-by: Nate Koenig <nate@openrobotics.org> * Add tests to #81 (#82) This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
* Fix env parsing by placing it before executable parsing Signed-off-by: Nate Koenig <nate@openrobotics.org> * Add tests to #81 (#82) This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* Fix env parsing by placing it before executable parsing (#81) * Fix env parsing by placing it before executable parsing Signed-off-by: Nate Koenig <nate@openrobotics.org> * Add tests to #81 (#82) This adds a simple check to verify that the env directives apply to everything in the ignition namespace, as fixed in #81. The test itself is a bit of a workaround. We don't have a mechanism for checking the manager output, and executable command directives cannot expand environment variables. This writes a script that is executed by the test to verify that a file specified by an environment variable is touch-ed Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org> * Prep for 2.2.1 release (#84) Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
chapulina
added
beta
Codecov Report
@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 29.01% 30.24% +1.22%
==========================================
Files 3 3
Lines 734 734
==========================================
+ Hits 213 222 +9
+ Misses 521 512 -9
Continue to review full report at Codecov.
|
ahcorde
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
There are 3 new warnings in the buildfarm https://build.osrfoundation.org/job/ignition_launch-ci-pr_any-ubuntu_auto-amd64/387/ but I think they are coming from other packages.
|
There are some references to There's also a reference to |
chapulina
force-pushed
the
chapulina/3_to_4
branch
from
a6b17a3 to
a551438
Compare
|
Addressed @adlarkin 's comments and force-pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-launch3tomain.Branch comparison: main...ign-launch3
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸