Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : gz-launch #162

Merged
merged 4 commits into from
May 16, 2022
Merged

ign -> gz Header Migration : gz-launch #162

merged 4 commits into from
May 16, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from nkoenig as a code owner May 12, 2022 05:35
@methylDragon methylDragon marked this pull request as draft May 12, 2022 05:36
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 12, 2022
@methylDragon methylDragon marked this pull request as ready for review May 12, 2022 05:46
@methylDragon methylDragon mentioned this pull request May 12, 2022
Closed
@methylDragon
Move header files with git mv (#162)
1cdbc18 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Create redirection aliases (#162)
4ed722a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate sources in src, test, examples, and include (#162)
d140df7 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate CMake files (#162)
1ac9b6b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 12, 2022
@methylDragon
Copy link
Contributor Author

methylDragon commented May 12, 2022 •
edited
Loading

Windows CI builds, but with warnings: https://build.osrfoundation.org/job/ign_launch-pr-win/302/msbuild/new/#issuesContent

Some leaked from gz-transport and gz-msgs
Some leaked from Ogre2

But I also see some stuff from random:

'argument': conversion from 'size_t' to 'std::seed_seq::result_type', possible loss of data

@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 12, 2022
chapulina
chapulina approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 16, 2022
@methylDragon methylDragon merged commit 08b72e8 into main May 16, 2022
@methylDragon methylDragon deleted the header_migration branch May 16, 2022 17:57
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Move header files with git mv (#162)
907f0df 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Create redirection aliases (#162)
cec1bcd 
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon added a commit that referenced this pull request May 16, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#162)
121d0d8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina