Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-launch #163

Merged
merged 31 commits into from
May 29, 2022
Merged

ign -> gz Namespace Migration : gz-launch #163

merged 31 commits into from
May 29, 2022

Conversation

methylDragon
Copy link
Contributor

Also catches hopefully all of the remaining header guards.
CI is expected to fail because upstream namespaces would not have been merged/migrated yet.

See gazebo-tooling/release-tools#711

@methylDragon
Update namespace definitions and using statements
58bd75e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate ignition::gazebo to gz::sim
ac6c93c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate ignition:: to gz::
4bceecc 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update header guards
c0e66f9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon requested a review from nkoenig as a code owner May 16, 2022 23:34
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 16, 2022
@methylDragon methylDragon mentioned this pull request May 16, 2022
Closed
@methylDragon
Use deprecation trick and implement test
7e31ad5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add migration line
9d9dd22 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina reviewed May 17, 2022
View reviewed changes
test/integration/deprecated_TEST.cc Show resolved Hide resolved
include/gz/launch/config.hh.in Outdated Show resolved Hide resolved
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label May 17, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 17, 2022
@methylDragon
Add copyright to deprecation test
5b7857f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh
5d0d44f 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Ticktock config macros
3b53949 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch from 34579d5 to 3b53949 Compare May 19, 2022 22:40
@methylDragon
Mention gz headers in migration
bed056e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate includes to gz
1113313 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina reviewed May 20, 2022
View reviewed changes
Migration.md Show resolved Hide resolved
src/Manager.cc Show resolved Hide resolved
include/ignition/launch/config.hh Outdated Show resolved Hide resolved
include/gz/launch/config.hh.in Outdated Show resolved Hide resolved
src/cmd/ign.cc Show resolved Hide resolved
include/gz/launch/config.hh.in Show resolved Hide resolved
@methylDragon
Update config.hh
4e14c74 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update migration
b902b64 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch 2 times, most recently from 4ce7279 to bc10f25 Compare May 20, 2022 08:32
@methylDragon
Migrate Export.hh macros, CMake install vars, and the deprecated test
d04b696 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch from bc10f25 to d04b696 Compare May 20, 2022 08:59
@methylDragon
Migrate github links
6a2e3f3 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate user-facing Ignition to Gazebo
82fc395 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Fix broken references
68814de 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert plugin names to ignition-gazebo
52bdc8a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate "ignition.msgs" -> "gz.msgs"
3646ee8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Include config.hh in recursive directories and <lib>.hh
382fe17 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Gazebo Robotics -> Gazebo
d678d7e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
ignitionrobotics -> gazebosim
a99bec8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Revert migration for fuel.ignitionrobotics.org
0753c8b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Rollback osrf-migration.github.io migrations
643b2b2 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Wording changes
08d9cf9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina suggested changes May 25, 2022
View reviewed changes
src/Manager.cc Show resolved Hide resolved
@methylDragon
Migrate igndbg -> gzdbg
91282c4 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch from bff5706 to 91282c4 Compare May 25, 2022 22:59
@methylDragon
Tick-tock plugin finding (IGN_LAUNCH_PLUGIN_PATH)
702f452 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI. It would be nice to print warnings when the user finds a plugin through a deprecated path or env var, and we should document the env var and path migration on the changelog.

src/Manager.cc Show resolved Hide resolved
@methylDragon
Add tick-tock warning and changelog entry for IGN_LAUNCH_PLUGIN_PATH
223814b 
Signed-off-by: methylDragon <methylDragon@gmail.com>
chapulina
chapulina suggested changes May 26, 2022
View reviewed changes
include/gz/launch/config.hh.in Outdated Show resolved Hide resolved
Changelog.md Outdated Show resolved Hide resolved
src/Manager.cc Outdated Show resolved Hide resolved
@methylDragon
Update migration
feb94cd 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch 3 times, most recently from b380a40 to a2c3ecf Compare May 26, 2022 23:11
chapulina
chapulina approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI!

@methylDragon
Fix IGN_LAUNCH_PLUGIN_PATH logic
b51b2aa 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the namespace_migration branch from a2c3ecf to b51b2aa Compare May 26, 2022 23:23
@chapulina chapulina mentioned this pull request May 27, 2022
Closed
49 tasks
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
@chapulina chapulina merged commit 8a74fac into main May 29, 2022
@chapulina chapulina deleted the namespace_migration branch May 29, 2022 21:10
@chapulina chapulina mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina