Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completion for flags #167

Merged
merged 5 commits into from
Jun 15, 2022
Merged

Bash completion for flags #167

merged 5 commits into from
Jun 15, 2022

Conversation

mabelzhang
Copy link
Contributor

🎉 New feature

Part of gazebosim/gz-tools#1
Used together with gazebosim/gz-tools#87

Summary

Bash completion, installation, tests.

Test it

$ . install/share/gz/gz1.completion
$ ign launch -
--force-version  --help           --verbose        --versions       -h               -v

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang added the OOBE 📦✨ Out-of-box experience label Jun 7, 2022
@mabelzhang mabelzhang requested review from ahcorde and chapulina June 7, 2022 08:07
@mabelzhang mabelzhang requested a review from nkoenig as a code owner June 7, 2022 08:07
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jun 7, 2022
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina enabled auto-merge (squash) June 15, 2022 00:36
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-launch2@0c6eaa5). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             ign-launch2     #167   +/-   ##
==============================================
  Coverage               ?   30.24%           
==============================================
  Files                  ?        3           
  Lines                  ?      734           
  Branches               ?        0           
==============================================
  Hits                   ?      222           
  Misses                 ?      512           
  Partials               ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c6eaa5...2937d5d. Read the comment docs.

@chapulina chapulina merged commit 66f0b31 into ign-launch2 Jun 15, 2022
@chapulina chapulina deleted the mabelzhang/tab_completion branch June 15, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants