Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Migrate Ignition Headers : gz-launch #191

Open
wants to merge 11 commits into
base: ign-launch2
Choose a base branch
from
Open

ign -> gz Migrate Ignition Headers : gz-launch #191

wants to merge 11 commits into from

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from nkoenig as a code owner August 12, 2022 22:37
@methylDragon methylDragon mentioned this pull request Aug 12, 2022
Open
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 12, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 15, 2022
@methylDragon methylDragon force-pushed the citadel_header_redirects branch from 8ff77a2 to 2e370eb Compare August 18, 2022 22:27
@codecov
Copy link

codecov bot commented Aug 18, 2022 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26b7007) 56.74% compared to head (2e370eb) 56.74%.
Report is 10 commits behind head on ign-launch2.

❗ Current head 2e370eb differs from pull request most recent head db2b78f. Consider uploading reports for the commit db2b78f to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           ign-launch2     #191   +/-   ##
============================================
  Coverage        56.74%   56.74%           
============================================
  Files                2        2           
  Lines              326      326           
============================================
  Hits               185      185           
  Misses             141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@methylDragon
Migrate headers
9f50db5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 6 times, most recently from 45fd096 to 753bf77 Compare August 19, 2022 03:00
@methylDragon
Add redirection headers
4037852 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch from 753bf77 to 4037852 Compare August 19, 2022 03:03
@methylDragon
Migrate include statements
6c71217 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch from b556f32 to 6c71217 Compare August 19, 2022 03:47
@methylDragon methylDragon changed the title ign -> gz Reverse Ignition Headers : gz-launch ign -> gz Migrate Ignition Headers : gz-launch Aug 22, 2022
@methylDragon methylDragon force-pushed the citadel_header_redirects branch 2 times, most recently from 60d677e to da22e03 Compare August 30, 2022 20:58
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Sep 3, 2022
@methylDragon
Leave ignition as primary in headers to fix ABI
f5f5a68 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the citadel_header_redirects branch from da22e03 to f5f5a68 Compare September 5, 2022 23:44
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 31, 2023
@mjcarroll
Merge branch 'ign-launch2' into citadel_header_redirects
de78fd4 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Add newline
c73ef80 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@azeey azeey removed the beta Targeting beta release of upcoming collection label Aug 18, 2023
@azeey
Copy link
Contributor

azeey commented Dec 5, 2023

@osrf-jenkins run tests please

@nkoenig
Merge branch 'ign-launch2' into citadel_header_redirects
25c856d
@nkoenig
Fixing compilation
370d2f6 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Fix test
2ee7d77 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
Added missing include
32ea67a 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@nkoenig
use include
db2b78f 
Signed-off-by: Nate Koenig <natekoenig@gmail.com>
@azeey azeey added beta Targeting beta release of upcoming collection and removed beta Targeting beta release of upcoming collection labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoenig nkoenig nkoenig approved these changes

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methylDragon @azeey @nkoenig @chapulina @mjcarroll