Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing include #162

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Add missing include #162

merged 1 commit into from
Sep 30, 2020

Conversation

Tobias-Fischer
Copy link
Contributor

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, it looks good to me. Do you mind amending your commit and signing it for the DCO check?

Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
@Tobias-Fischer
Copy link
Contributor Author

Done

@chapulina chapulina merged commit b5306cc into gazebosim:master Sep 30, 2020
@traversaro
Copy link
Contributor

It would be convenient for me to have this fix also in ign-math6 branch. @chapulina what workflow do you suggested in this case? I can just go on and open a PR against ign-math6, or you prefer to handle this via some internal cherry-pick ?

chapulina pushed a commit that referenced this pull request Nov 10, 2020
Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
@chapulina
Copy link
Contributor

I cherry-picked it on #177. It doesn't need to be internal, everyone is welcome to open the backport / forward-port PRs 😉

@traversaro
Copy link
Contributor

I cherry-picked it on #177. It doesn't need to be internal, everyone is welcome to open the backport / forward-port PRs 😉

Thanks, good to know!

chapulina pushed a commit that referenced this pull request Nov 11, 2020
Signed-off-by: Tobias Fischer <info@tobiasfischer.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants