Add Helpers Python interface #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ahcorde <ahcorde@gmail.com>
github-actions
bot
added
Gazebo 1️1️
Codecov Report
@@ Coverage Diff @@
## ign-math6 #251 +/- ##
==========================================
Coverage 99.41% 99.41%
==========================================
Files 67 67
Lines 6351 6374 +23
==========================================
+ Hits 6314 6337 +23
Misses 37 37
Continue to review full report at Codecov.
|
|
friendly ping @scpeters |
scpeters
reviewed
Oct 9, 2021
| # Test Helpers::fixnan functions | ||
| def test_fix_nan(self): | ||
| self.assertEqual(fixnan(42.0), 42.0) | ||
| self.assertEqual(fixnan(-42.0), -42.0) |
There was a problem hiding this comment.
is there a way to pass nan values in python? there are a few lines in the c++ test that aren't included here
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
This was referenced Oct 11, 2021
scpeters
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Summary
Added Helper Python interface. I made some tricks to make it work which are explained in the
Helpers.iChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge