Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphere Python interface #277

Merged
merged 3 commits into from
Oct 30, 2021
Merged

Sphere Python interface #277

merged 3 commits into from
Oct 30, 2021

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 29, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

🎉 New feature

Summary

Added Sphere Python interface.

It depends on #272

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from scpeters October 29, 2021 09:59
@ahcorde ahcorde self-assigned this Oct 29, 2021
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🌱 garden Ignition Garden 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Oct 29, 2021
@chapulina chapulina added the scripting Scripting interfaces to Ignition label Oct 29, 2021
@scpeters scpeters changed the title Added Sphere Python interface Sphere Python interface Oct 29, 2021
@scpeters
Copy link
Member

didn't notice this depends on #272; I will review that first

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait for #272

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #277 (b6a13bb) into ign-math6 (db5edbf) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-math6     #277      +/-   ##
=============================================
+ Coverage      99.21%   99.41%   +0.20%     
=============================================
  Files             65       67       +2     
  Lines           6087     6374     +287     
=============================================
+ Hits            6039     6337     +298     
+ Misses            48       37      -11     
Impacted Files Coverage Δ
include/ignition/math/AxisAlignedBox.hh 100.00% <ø> (ø)
include/ignition/math/Box.hh 100.00% <ø> (ø)
include/ignition/math/Cylinder.hh 100.00% <ø> (ø)
include/ignition/math/Ellipsoid.hh 100.00% <ø> (ø)
include/ignition/math/Sphere.hh 100.00% <ø> (ø)
eigen3/include/ignition/math/eigen3/Util.hh 100.00% <100.00%> (ø)
include/ignition/math/Line2.hh 100.00% <100.00%> (ø)
include/ignition/math/Line3.hh 100.00% <100.00%> (ø)
include/ignition/math/Plane.hh 100.00% <100.00%> (ø)
include/ignition/math/Pose3.hh 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200a7ff...b6a13bb. Read the comment docs.

@scpeters scpeters merged commit 3dd836f into ign-math6 Oct 30, 2021
@scpeters scpeters deleted the ahcorde/python/sphere branch October 30, 2021 01:11
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-01-citadel-edifice-fortress/1313/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress 🌱 garden Ignition Garden Gazebo 1️1️ Dependency of Gazebo classic version 11 scripting Scripting interfaces to Ignition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants