Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-math #462

Merged
merged 2 commits into from
Jul 13, 2022
Merged

ign -> gz CMake, Python, Partial Source, and File Migrations : gz-math #462

merged 2 commits into from
Jul 13, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jul 12, 2022
Closed
32 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 12, 2022
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

scpeters
scpeters reviewed Jul 12, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interval python test failed:

128: Traceback (most recent call last):
128:   File "/Users/jenkins/workspace/ignition_math-ci-pr_any-homebrew-amd64/ign-math/src/python_pybind11/test/Interval_TEST.py", line 17, in <module>
128:     from ignition.math import Intervald
128: ModuleNotFoundError: No module named 'ignition.math'
128/165 Test #128: Interval_TEST.py ..................................***Failed    0.12 sec

the python test failures don't show up in homebrew CI unfortunately

CMakeLists.txt Outdated
@@ -18,7 +18,7 @@ set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)

gz_configure_project(
REPLACE_IGNITION_INCLUDE_PATH gz/math
REPLACE_INCLUDE_PATH gz/math
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed since the default path is gz/math as of gazebosim/gz-cmake#277

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here and everywhere else 008784a

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch 2 times, most recently from 4b6a0a4 to 008784a Compare July 12, 2022 20:55
@methylDragon
Copy link
Contributor Author

methylDragon commented Jul 12, 2022 •
edited
Loading

Interval python test failed:

128: Traceback (most recent call last):
128:   File "/Users/jenkins/workspace/ignition_math-ci-pr_any-homebrew-amd64/ign-math/src/python_pybind11/test/Interval_TEST.py", line 17, in <module>
128:     from ignition.math import Intervald
128: ModuleNotFoundError: No module named 'ignition.math'
128/165 Test #128: Interval_TEST.py ..................................***Failed    0.12 sec

the python test failures don't show up in homebrew CI unfortunately

New build has it passing: https://build.osrfoundation.org/job/ignition_math-ci-pr_any-homebrew-amd64/1826/consoleFull

There was a bug in how the symlinks were being installed/created. Fixed here and in sim.

127/165 Test #127: Inertial_TEST.py ..................................   Passed    0.14 sec
test 128
        Start 128: Interval_TEST.py

128: Test command: /Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/bin/python3.8 "/Users/jenkins/workspace/ignition_math-ci-pr_any-homebrew-amd64/ign-math/src/python_pybind11/test/Interval_TEST.py"
128: Environment variables: 
128:  PYTHONPATH=/Users/jenkins/workspace/ignition_math-ci-pr_any-homebrew-amd64/build/fake/install/lib/python/
128:  LD_LIBRARY_PATH=/Users/jenkins/workspace/ignition_math-ci-pr_any-homebrew-amd64/build/fake/install/lib:
128: Test timeout computed to be: 1500
128: ........
128: ----------------------------------------------------------------------
128: Ran 8 tests in 0.001s
128: 
128: OK
128/165 Test #128: Interval_TEST.py ..................................   Passed    0.12 sec
test 129

scpeters
scpeters requested changes Jul 12, 2022
View reviewed changes
tutorials/installation.md Outdated
```
See the [Conda release repository](https://github.com/conda-forge/libignition-math4-feedstock) for more information.
See the [Conda release repository](https://github.com/conda-forge/libgz-math4-feedstock) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this conda link doesn't work with the change. I'm not sure if any of the conda portion should be migrated actually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! bc118cb

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from 008784a to bc118cb Compare July 12, 2022 23:42
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from bc118cb to c5ade3a Compare July 13, 2022 00:17
@codecov
Copy link

codecov bot commented Jul 13, 2022 •
edited
Loading

Codecov Report

Merging #462 (0d60a5a) into main (0718094) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d60a5a differs from pull request most recent head 1d1be5c. Consider uploading reports for the commit 1d1be5c to get more accurate results

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          74       74           
  Lines        6845     6845           
=======================================
  Hits         6824     6824           
  Misses         21       21
Impacted Files Coverage Δ
eigen3/include/gz/math/eigen3/Conversions.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0718094...1d1be5c. Read the comment docs.

@methylDragon
Move pybind file (#462)
db63e23 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Partial source and cmake migrations (#462)
1d1be5c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ci_matching_branch/file_and_source_migration branch from c5ade3a to 1d1be5c Compare July 13, 2022 08:12
@methylDragon methylDragon merged commit 49eba8f into main Jul 13, 2022
@methylDragon methylDragon deleted the ci_matching_branch/file_and_source_migration branch July 13, 2022 08:46
methylDragon added a commit that referenced this pull request Jul 13, 2022
@methylDragon
Move pybind file (#462)
019813c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995 adityapande-1995 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @scpeters