Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Tick-tock Python Libs : gz-math #466

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon commented Jul 14, 2022

Part of overarching: gazebo-tooling/release-tools#698
Follow-up to: gazebo-tooling/release-tools#765

In gazebo-tooling/release-tools#765, gz-math Python bindings were tick-tocked to allow use of ignition and gz. But the symlinks that are being created on the debbuilder are malformed, even though local builds work fine...

This PR fixes that by abusing relative links (it breaks on absolute links for some reason.)

Compare the built .deb from this

Test downstream build using fixed debbuild: Build Status
Build is unstable because of deprecation warnings, not test failures, which this fixes!

Signed-off-by: methylDragon <methylDragon@gmail.com>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 14, 2022
@chapulina chapulina added scripting Scripting interfaces to Ignition ign to gz Renaming Ignition to Gazebo. labels Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #466 (8496dbe) into main (49eba8f) will not change coverage.
The diff coverage is n/a.

❗ Current head 8496dbe differs from pull request most recent head 2c20008. Consider uploading reports for the commit 2c20008 to get more accurate results

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   99.69%   99.69%           
=======================================
  Files          74       74           
  Lines        6845     6845           
=======================================
  Hits         6824     6824           
  Misses         21       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49eba8f...2c20008. Read the comment docs.

@methylDragon
Copy link
Contributor Author

Build is unstable because of deprecation warnings, not test failures, which this fixes!

@methylDragon methylDragon enabled auto-merge (squash) July 15, 2022 00:15
@methylDragon methylDragon merged commit 931d2e9 into main Jul 15, 2022
@methylDragon methylDragon deleted the ci_matching_branch/fix_python branch July 15, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. scripting Scripting interfaces to Ignition
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants