-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build examples from CMake rather than executable #482
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
e6b9f87
to
af66e6e
Compare
Tested locally on Windows with:
I also found a neat side effect, this lets us additionally turn on
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@osrf-jenkins retest this please |
1 similar comment
@osrf-jenkins retest this please |
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, but CI is ugly, all python tests are failing
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
Codecov Report
@@ Coverage Diff @@
## gz-math7 #482 +/- ##
============================================
- Coverage 99.70% 94.34% -5.36%
============================================
Files 77 144 +67
Lines 7049 9660 +2611
============================================
+ Hits 7028 9114 +2086
- Misses 21 546 +525
|
🦟 Bug fix
Summary
Part of gazebosim/gz-cmake#301
Test by building gz-math as normal and then running the "EXAMPLES_Configure_TEST" and "EXAMPLES_Build_TEST" via ctest.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.