-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow moon and custom surfaces in spherical coords msg #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inition Signed-off-by: Aditya <aditya050995@gmail.com>
9 tasks
adityapande-1995
changed the title
Add moon and custom surfaces to conversion functions, updated msg def…
Allow moon and custom surfaces in spherical coords msg
Jul 19, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 85.44% 85.59% +0.14%
==========================================
Files 10 10
Lines 962 972 +10
==========================================
+ Hits 822 832 +10
Misses 140 140
Continue to review full report at Codecov.
|
Signed-off-by: Aditya <aditya050995@gmail.com>
jennuine
approved these changes
Jul 20, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
jennuine
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aditya aditya050995@gmail.com
🎉 New feature
Summary
Part of the feature : Supporting lunar DEMs and custom surfaces in spherical coordinates. Adds new fields
surface_axis_equatorial
andsurface_axis_polar
to spherical coordinates proto msg, allows new enumsMOON_SCS
andCUSTOM_SURFACE
.Test it
Added test cases.
Depends on
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸