Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve migration note on SphericalCoordinates #452

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Aug 22, 2024

🦟 Bug fix

Fixes #451 (comment)

Summary

Improvement of the migration note on SphericalCoordinates (as requested by @azeey )

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
@peci1 peci1 requested a review from caguero as a code owner August 22, 2024 16:58
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Aug 22, 2024
@mjcarroll mjcarroll merged commit a9922ea into gazebosim:main Aug 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants