Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link from message generation tutorial #458

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 3, 2024

🦟 Bug fix

An incorrect link is generated in the message generation tutorial.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero changed the title Remove link from message generation tutorial. Remove link from message generation tutorial Sep 3, 2024
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 3, 2024
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the sentence is right, but it is not right the automated generated link.

https://gazebosim.org/api/msgs/11/messagegeneration.html

@caguero
Copy link
Collaborator Author

caguero commented Sep 3, 2024

the sentence is right, but it is not right the automated generated link.

https://gazebosim.org/api/msgs/11/messagegeneration.html

@ahcorde , what's your requested change exactly?

@ahcorde
Copy link
Contributor

ahcorde commented Sep 3, 2024

the sentence is right, but it is not right the automated generated link.
https://gazebosim.org/api/msgs/11/messagegeneration.html

@ahcorde , what's your requested change exactly?

Try to find another syntax which not generate this automatic link

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero
Copy link
Collaborator Author

caguero commented Sep 11, 2024

Try to find another syntax which not generate this automatic link

It's subtle but I replaced the regular dot character with an alternative dot character and that doesn't generate the link.

Screenshot from 2024-09-11 19-28-12

@ahcorde ahcorde merged commit 74a20b2 into gz-msgs11 Sep 11, 2024
11 checks passed
@ahcorde ahcorde deleted the caguero/ionic/msg_generation_fix branch September 11, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants