Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning: implicitly-declared copy constructors are deprecated [-Wdeprecated-copy] #332

Closed
chapulina opened this issue Mar 14, 2022 · 2 comments
Closed

Warning: implicitly-declared copy constructors are deprecated [-Wdeprecated-copy] #332

chapulina opened this issue Mar 14, 2022 · 2 comments
Assignees
@mjcarroll
Labels
bug Something isn't working

Comments

@chapulina
Copy link
Contributor

Environment

  • OS Version: Ubuntu Focal
  • Source or binary build? Source

Description

  • Expected behavior: No warnings
  • Actual behavior: Compiler warnings

Steps to reproduce

Compile on Focal, or check Jenkins CI:

https://build.osrfoundation.org/job/ignition_physics-ci-pr_any-ubuntu_auto-amd64/1535/consoleFull

Output

                 from /home/jenkins/workspace/ignition_physics-ci-pr_any-ubuntu_auto-amd64/ign-physics/src/SpecifyData_TEST.cc:22:
/home/jenkins/workspace/ignition_physics-ci-pr_any-ubuntu_auto-amd64/ign-physics/include/ignition/physics/SpecifyData.hh: In member function ‘ignition::physics::RequireData<StringData>& ignition::physics::RequireData<StringData>::operator=(const ignition::physics::RequireData<StringData>&)’:
/home/jenkins/workspace/ignition_physics-ci-pr_any-ubuntu_auto-amd64/ign-physics/include/ignition/physics/SpecifyData.hh:173:11: warning: implicitly-declared ‘ignition::physics::ExpectData<StringData>& ignition::physics::ExpectData<StringData>::operator=(const ignition::physics::ExpectData<StringData>&)’ is deprecated [-Wdeprecated-copy]
  173 |     class RequireData<Required> : public virtual ExpectData<Required>
      |           ^~~~~~~~~~~~~~~~~~~~~
@chapulina chapulina added the bug Something isn't working label Mar 14, 2022
@chapulina chapulina mentioned this issue Mar 14, 2022
Open
@chapulina
Copy link
Contributor Author

I removed the requirement for ignition_physics-ci-pr_any-ubuntu_auto-amd64 to pass before merging PRs into main, and updated

mjcarroll added a commit that referenced this issue Mar 15, 2022
@mjcarroll
Remove deprecated copies
734fb51 
Addresses #332

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll mentioned this issue Mar 15, 2022
Merged
mjcarroll added a commit that referenced this issue Mar 15, 2022
@mjcarroll
Implement user assign operator to avoid implicit
ddf028b 
Addresses #332

Signed-off-by: Michael Carroll <michael@openrobotics.org>
scpeters pushed a commit that referenced this issue Mar 28, 2022
@mjcarroll
Fix ExpectData compiler warnings (#335)
c36aee7 
Use default assignment operator.
Addresses #332.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
azeey pushed a commit to azeey/gz-physics that referenced this issue Mar 28, 2022
@mjcarroll @azeey
Fix ExpectData compiler warnings (gazebosim#335)
8cc2eef 
Use default assignment operator.
Addresses gazebosim#332.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
azeey pushed a commit to azeey/gz-physics that referenced this issue Mar 30, 2022
@mjcarroll @azeey
Fix ExpectData compiler warnings (gazebosim#335)
3f28ba0 
Use default assignment operator.
Addresses gazebosim#332.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
scpeters pushed a commit that referenced this issue Mar 30, 2022
@mjcarroll @scpeters
Fix ExpectData compiler warnings (#335)
7a52fdd 
Use default assignment operator.
Addresses #332.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Contributor

Closed by #335 and friends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjcarroll mjcarroll

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjcarroll @chapulina