Bumps in fortress : ign-physics5

[chapulina]

See gazebo-tooling/release-tools#428

[chapulina]

@osrf-jenkins run tests again, they should work now

[codecov]

Codecov Report

Merging #246 (d9835f1) into main (d80f241) will not change coverage.
The diff coverage is n/a.

❗ Current head d9835f1 differs from pull request most recent head e7a6575. Consider uploading reports for the commit e7a6575 to get more accurate results

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   82.39%   82.39%           
=======================================
  Files         109      109           
  Lines        4522     4522           
=======================================
  Hits         3726     3726           
  Misses        796      796           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d80f241...e7a6575. Read the comment docs.

[adlarkin]

Can this comment be updated?

https://github.com/ignitionrobotics/ign-physics/blob/bump_fortress_ign-physics5/sdf/include/ignition/physics/sdf/ConstructNestedModel.hh#L29-L31

[chapulina]

Can this comment be updated?

I don't think it should say sdf12 because model composition got into sdf11. I think the most appropriate action would be to update it when nested model support is complete, see #231. CC @azeey

[adlarkin]

I don't think it should say sdf12 because model composition got into sdf11. I think the most appropriate action would be to update it when nested model support is complete, see #231

Correct, what I was wondering is if the comment could be deleted altogether. However, since it appears support isn't fully completefd yet (#231), I think it's fine as is. I just wasn't aware of the current status of nested model support, so I was asking just to be sure 👍