Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 (main) #321

Merged
merged 15 commits into from
Dec 28, 2021
Merged

5 ➡️ 6 (main) #321

merged 15 commits into from
Dec 28, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Tobias-Fischer and others added 15 commits October 25, 2021 12:07
Signed-off-by: Tobias-Fischer <t.fischer@imperial.ac.uk>
Running the original test with AddressSanitizer gives stack-use-after-scope.
Reference: "C++11 and the auto keyword"
https://eigen.tuxfamily.org/dox/TopicPitfalls.html

Signed-off-by: Hill Ma <hillma@google.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Adds support for registering callbacks that modify properties of all contacts generated by the dynamics engine. Example implementation for DART is provided.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* Added DART feature for setting joint limits dynamically.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Make code compatible with older DART release (this commit can be reverted once newer DART is out).

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Updated the number of models for test.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Apply suggestions from code review

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>

* Fixed issues from review.

Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>

* Accomodate DART 6.9

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Addisu Z. Taddese <addisu@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
The header template provided by ign-cmake is used instead.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #321 (eeefd45) into main (acf393d) will increase coverage by 0.19%.
The diff coverage is 88.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   75.54%   75.73%   +0.19%     
==========================================
  Files         127      129       +2     
  Lines        5655     5762     +107     
==========================================
+ Hits         4272     4364      +92     
- Misses       1383     1398      +15     
Impacted Files Coverage Δ
dartsim/src/SimulationFeatures.cc 85.40% <85.00%> (-5.83%) ⬇️
dartsim/src/SimulationFeatures.hh 100.00% <100.00%> (ø)
...clude/ignition/physics/detail/ContactProperties.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf393d...eeefd45. Read the comment docs.

@chapulina chapulina merged commit 73542fa into main Dec 28, 2021
@chapulina chapulina deleted the chapulina/5_to_6 branch December 28, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants