Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bionic from future releases (Garden+) #331

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

chapulina
Copy link
Contributor

Summary

ign-physics6 will be on Garden.

Test it

No Bionic builds should be triggered.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 11, 2022
@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #331 (522c4bd) into main (224a7e0) will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   76.07%   75.61%   -0.46%     
==========================================
  Files         129      128       -1     
  Lines        5726     5541     -185     
==========================================
- Hits         4356     4190     -166     
+ Misses       1370     1351      -19     
Impacted Files Coverage Δ
dartsim/src/JointFeatures.cc 58.24% <0.00%> (-6.60%) ⬇️
dartsim/src/ShapeFeatures.cc 36.66% <0.00%> (-3.71%) ⬇️
dartsim/src/SDFFeatures.cc 62.71% <0.00%> (-0.18%) ⬇️
tpe/lib/src/Shape.hh 100.00% <0.00%> (ø)
include/ignition/physics/detail/Joint.hh 100.00% <0.00%> (ø)
include/ignition/physics/detail/Shape.hh 100.00% <0.00%> (ø)
...clude/ignition/physics/detail/ContactProperties.hh
...nclude/ignition/physics/detail/RelativeQuantity.hh 91.95% <0.00%> (+0.09%) ⬆️
dartsim/src/SimulationFeatures.cc 90.16% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224a7e0...522c4bd. Read the comment docs.

@chapulina
Copy link
Contributor Author

I cancelled the Windows build because the buildfarm is swamped and that shouldn't be affected by this PR.

The warnings on Ubuntu Jenkins aren't new.

I think this is good to go!

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 5a5a974 into main Mar 14, 2022
@chapulina chapulina deleted the chapulina/main/rm/bionic branch March 14, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants