Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Provisional Finale: Source Migration : gz-physics #383

Merged
merged 1 commit into from
Jul 15, 2022
Merged

ign -> gz Provisional Finale: Source Migration : gz-physics #383

merged 1 commit into from
Jul 15, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jul 14, 2022
Closed
18 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jul 14, 2022
@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #383 (a5e74c9) into main (795bc06) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   76.77%   76.77%           
=======================================
  Files         128      128           
  Lines        5628     5628           
=======================================
  Hits         4321     4321           
  Misses       1307     1307
Impacted Files Coverage Δ
dartsim/src/SimulationFeatures.cc 90.16% <ø> (ø)
dartsim/src/SimulationFeatures.hh 100.00% <ø> (ø)
dartsim/src/CustomHeightmapShape.cc 94.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795bc06...a5e74c9. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jul 14, 2022
@methylDragon
Finale: Source hard-tocks
a5e74c9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ci_matching_branch/finale branch from 2027b5a to a5e74c9 Compare July 15, 2022 00:34
ahcorde
ahcorde reviewed Jul 15, 2022
View reviewed changes
Changelog.md
@@ -69,7 +69,7 @@

### Gazebo Physics 4.3.0 (2021-11-11)

1. Remove unused ign_auto_headers.hh.in
1. Remove unused gz_auto_headers.hh.in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no really sure if you should modify the Changelog

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This came up before, I think we were ok with modifying it to whittle down the number of cases, so I'll just accept this one too :o

@methylDragon methylDragon merged commit b2d3797 into main Jul 15, 2022
@methylDragon methylDragon deleted the ci_matching_branch/finale branch July 15, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@mxgrey mxgrey Awaiting requested review from mxgrey

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @ahcorde @chapulina