Restore detached BodyNodes to original skeleton #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scpeters
requested changes
May 4, 2020
scpeters
approved these changes
May 7, 2020
…eTo in Attach*Joint, then try to restore BodyNode to its original skeleton if / is detected in child BodyNode's name during DetachJoint JointFeatures_TEST.cc edited online with Bitbucket JointFeatures.hh: revert changes Store the original name of links for use in moving BodyNodes between skeletons Failing test demonstrating problem when a model and link have the same name Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Handle the case when model and link names are the same Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Typo Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
force-pushed
the
detach_joint_feature_detach_to_skeleton
branch
from
1a46caf to
de17f64
Compare
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is was originally opened by @scpeters before the Github migration (archived PR). I have modified it to store the original names of links and using those names when moving BodyNodes between skeletons.