Skip to content

Commit

Permalink
Finale: Tick-tock IgnitionFormatter
Browse files Browse the repository at this point in the history
Signed-off-by: methylDragon <methylDragon@gmail.com>
  • Loading branch information
methylDragon committed Jul 15, 2022
1 parent 2a1ddee commit b91ad98
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions MigrationFromCommon.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ The name of the header for registering plugins has changed:
The old `gz-common` plugin registration method had numerous macros for registering
plugins. Those have all been replaced with `GZ_ADD_PLUGIN`. Specifically:

* `IGNITION_COMMON_REGISTER_SINGLE_MACRO` can be directly replaced with `GZ_ADD_PLUGIN`.
* `IGNITION_COMMON_ADD_PLUGIN` can be directly replaced with `GZ_ADD_PLUGIN`.
* All uses of `IGNITION_COMMON_BEGIN_ADDING_PLUGINS` can simply be removed.
* All uses of `IGNITION_COMMON_FINISH_ADDING_PLUGINS` can simply be removed.
* All uses of `IGNITION_COMMON_SPECIALIZE_INTERFACE` can simply be removed. Interfaces no longer need to be "specialized" in order to have specialized plugins.
* `IGN_COMMON_REGISTER_SINGLE_MACRO` can be directly replaced with `GZ_ADD_PLUGIN`.
* `IGN_COMMON_ADD_PLUGIN` can be directly replaced with `GZ_ADD_PLUGIN`.
* All uses of `IGN_COMMON_BEGIN_ADDING_PLUGINS` can simply be removed.
* All uses of `IGN_COMMON_FINISH_ADDING_PLUGINS` can simply be removed.
* All uses of `IGN_COMMON_SPECIALIZE_INTERFACE` can simply be removed. Interfaces no longer need to be "specialized" in order to have specialized plugins.

You can also register multiple interfaces with a single call to `GZ_ADD_PLUGIN`, e.g.:

Expand Down
2 changes: 1 addition & 1 deletion loader/src/cmd/plugin_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,6 @@ int main(int argc, char** argv)

addPluginFlags(app);

app.formatter(std::make_shared<IgnitionFormatter>(&app));
app.formatter(std::make_shared<GzFormatter>(&app));
CLI11_PARSE(app, argc, argv);
}

0 comments on commit b91ad98

Please sign in to comment.