Added standalone executable #65
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
=======================================
Coverage 99.82% 99.83%
=======================================
Files 15 16 +1
Lines 584 615 +31
=======================================
+ Hits 583 614 +31
Misses 1 1
Continue to review full report at Codecov.
|
|
@scpeters, I will open another PR to enable windows UNIT_IGN_TEST |
There was a problem hiding this comment.
made a few minor comments; this looks really good
there's one kinda confusing part in the help string generated by cli11, so I opened a feature request in ign-utils about improving the formatting ( gazebosim/gz-utils#28 ), but it's not blocking this PR for me
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
to improve coverage, perhaps we need to add to |
loader/src/cmd/CMakeLists.txt
Outdated
| @@ -29,7 +52,7 @@ set(cmd_script_configured "${CMAKE_CURRENT_BINARY_DIR}/cmd${IGN_DESIGNATION}${PR | |||
|
|
|||
| # Set the library_location variable to the relative path to the library file | |||
| # within the install directory structure. | |||
| set(library_location "../../../${CMAKE_INSTALL_LIBDIR}/$<TARGET_FILE_NAME:${loader}>") | |||
| set(plugin_exe_location "${CMAKE_INSTALL_PREFIX}/${INSTALL_STANDALONE_EXECUTABLE}/$<TARGET_FILE_NAME:${plugin_executable}>") | |||
There was a problem hiding this comment.
actually, I think we want to keep it as a relative path so that the ruby file is relocatable. The ../../.. is to back out from lib/ruby/ignition (see line 67)
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: ahcorde ahcorde@gmail.com
🎉 New feature
Depends on #64
Related with this issue #54
Summary
Added standalone executable. This should improve Windows support.
There is no tests, I need to add them
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge