Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ign to gz] C++ namespaces #75

Closed
wants to merge 4 commits into from
Closed

[ign to gz] C++ namespaces #75

wants to merge 4 commits into from

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Apr 12, 2022

🎉 New feature

Summary

Changes:

  • Change all namespaces from ignition to gz
  • Add alias so that ignition still works for users (tick-tock's tick)
  • Added a test to make sure ignition still works

Test it

See the added test. I also expect downstream libraries not to need any modifications because of this PR.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial - We'll add complete migration tutorials at the end
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Copy link
Contributor

Superceded by #83

@chapulina
Copy link
Contributor Author

See #83

@chapulina chapulina closed this May 17, 2022
@chapulina chapulina deleted the chapulina/2/gz_ns branch May 17, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants