Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Namespace migration (narrow) : gz-plugin #84

Closed
wants to merge 7 commits into from

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebo-tooling/release-tools#711, more narrow alternative to #83

Summary

This is an alternative to #83 (actually using some commits from that branch) that is narrower in scope. It avoids most macro changes in an attempt to simplify the review process.

Once these namespace changes start being merged, things will break, so we will try to merge them all relatively close together in time.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

scpeters and others added 6 commits May 22, 2022 03:11
~~~
sed -i -e 's@namespace ignition@namespace gz@g' \
  $(grep -rlI 'namespace ignition' .)
~~~

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
~~~
sed -i -e 's@ignition::@gz::@g' \
  $(grep -rlI 'ignition::' .)
~~~

Excluded changes to MIGRATION.md

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters closed this May 28, 2022
@scpeters scpeters deleted the scpeters/narrow_namepsace_migration branch March 6, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants